Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake installation by using GNUInstallDirs #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link

@Ryanf55 Ryanf55 commented Aug 7, 2023

* Don't override GNUInstallDirs
* This allows setting local prefix with cmake at installation time
* Use the new method in CI

Signed-off-by: Ryan Friedman <[email protected]>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Copy link
Member

pablogs9 commented Aug 7, 2023

Please take a look to the CI

@Ryanf55
Copy link
Author

Ryanf55 commented Aug 7, 2023

Ok, looks like the isolated build doesn't work.

2: CMake Error at /home/jenkins/workspace/Micro-XRCE-DDS-Agent Manual Linux/build/temp_install/isolated/share/microxrcedds_agent/cmake/microxrcedds_agentConfig.cmake:53 (find_package):
2:   By not providing "Findfastcdr.cmake" in CMAKE_MODULE_PATH this project has
2:   asked CMake to find a package configuration file provided by "fastcdr", but
2:   CMake did not find one.
2: 
2:   Could not find a package configuration file provided by "fastcdr"
2:   (requested version 1.1.0) with any of the following names:
2: 
2:     fastcdrConfig.cmake
2:     fastcdr-config.cmake
2: 
2:   Add the installation prefix of "fastcdr" to CMAKE_PREFIX_PATH or set
2:   "fastcdr_DIR" to a directory containing one of the above files.  If
2:   "fastcdr" provides a separate development package or SDK, be sure it has
2:   been installed.
2: Call Stack (most recent call first):
2:   CMakeLists.txt:19 (find_package)
2: 
2: 
2: -- Configuring incomplete, errors occurred!
2: See also "/home/jenkins/workspace/Micro-XRCE-DDS-Agent Manual Linux/build/microxrcedds_agent-build/test/case/CMakeFiles/CMakeOutput.log".
2: CMake Error at /home/jenkins/workspace/Micro-XRCE-DDS-Agent Manual Linux/test/case/packaging/Packaging.cmake:27 (message):
2:   Error in find_package.

Is it unreasonable to switch to using a package manager like CPM or even FetchContent which supports version pinning? The custom method implemented seems to be doing the same thing. There are better ways than calling git directly from CMake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants